In his view, criteria for judging teacher effectiveness could be based upon Shulman's categories of teacher knowledge —
especially academic content knowledge, pedagogical content knowledge, knowledge of the curriculum, and knowledge of learners and educational contexts.